Skip to content

Conversation

albercor
Copy link
Member

@albercor albercor commented Sep 7, 2026

  • implement favorite component and local storage
  • create css for favorite button
  • replace random id with number input in app
  • add favorite toggle to main view
  • bind search input to react query

Alberto added 2 commits September 7, 2026 18:12
* Build Favorite UI component with click handler
* Implement local storage sync directly within component state
* Add plain CSS for interactive hover states
* Add controlled number input for direct ID searching
* Bind input state to TanStack Query for reactive fetching
* Render Favorite component inside the main view
* Validate input to prevent negative numbers
@albercor albercor requested a review from a team as a code owner September 7, 2026 16:17
Copy link
Member

@thomhet thomhet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfinished - missing component that provides a list view of favorited pokemon.

otherwise looks good

@thomhet thomhet self-requested a review September 8, 2026 13:25
@thomhet
Copy link
Member

thomhet commented Sep 8, 2026

solves #3 #4 #2

@thomhet thomhet changed the title feat: add favorite component and search by id feat: all UI components, MVP implementation Sep 8, 2026
Copy link
Member

@thomhet thomhet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albercor albercor merged commit 7ce0913 into main Sep 8, 2026
@thomhet thomhet deleted the feat/favorite-component branch September 13, 2026 20:41
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants